Skip to content

Update agent collector config #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Update agent collector config #3396

merged 2 commits into from
May 22, 2025
+8 −10

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented May 22, 2025 •
edited
Loading

Problem: Agent updated the structure of the collector configuration.

Solution: Update our agent config template to match the new structure.

Testing: Verified that metrics still work.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

@sjberman
Update agent collector config
6f6d577 
Problem: Agent updated the structure of the collector configuration.

Solution: Update our agent config template to match the new structure.
@sjberman sjberman requested a review from a team as a code owner May 22, 2025 15:03
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels May 22, 2025
@codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (7854d84) to head (bc35201).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3396      +/-   ##
==========================================
+ Coverage   86.73%   86.78%   +0.05%     
==========================================
  Files         129      129              
  Lines       14928    14928              
  Branches       62       62              
==========================================
+ Hits        12948    12956       +8     
+ Misses       1828     1822       -6     
+ Partials      152      150       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) May 22, 2025 20:15
@sjberman sjberman merged commit ae0e46e into main May 22, 2025
52 of 53 checks passed
@sjberman sjberman deleted the chore/update-agent-config branch May 22, 2025 20:20
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjee19 bjee19 bjee19 approved these changes

@salonichf5 salonichf5 salonichf5 approved these changes

+1 more reviewer

@Bassa75338 Bassa75338 Bassa75338 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks dependencies Pull requests that update a dependency file

Projects

NGINX Gateway Fabric
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sjberman @Bassa75338 @bjee19 @salonichf5